👋 Welcome back mblaesing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@matthiasblaesing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353950: Clipboard interaction on Windows is unstable
8332271: Reading data from the clipboard from multiple threads crashes the JVM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• 56f04e1: 8337506: Disable "best-fit" mapping on Windows command line
• 352a641: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
• 636ceee: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter
• ... and 58 more: https://git.openjdk.org/jdk21u-dev/compare/9a6ef52b82e66dfd5779f66113c28371ff2fd776...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

This backport pull request has now been updated with issues from the original commit.

⚠️ @matthiasblaesing This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Webrevs

• 00: Full (c2fade9e)

Same testing as for master + jdk25 was applied to the backport:

• Tests from test/jdk/java/awt/Clipboard were successfully run with fastdebug and release configuration. It was verified, that the new test fails before the change and succeeds afterwards.
• Application level test already done with the original change were repeated and verified

Can I somehow help to get this into an JDK 21 update release?

This seems ok.

@matthiasblaesing You need to follow instructions for approval to move this forward. See #1911 (comment) and Contributing section in https://wiki.openjdk.org/display/JDKUpdates/JDK+21u

/approval

@matthiasblaesing usage: /approval [<id>] (request|cancel) [<text>]

/approval JDK-8353950 request Users indicated, that the flaky keyboard, resulting from NetBeans not being able to install historic clipboard fix because of SecurityManager removal is not acceptable behavior.

@matthiasblaesing
JDK-8353950: The approval request has been created successfully.

/approval JDK-8332271 request Crashing the VM with regular AWT calls is not acceptable and needs to be fixed.

@matthiasblaesing
JDK-8332271: The approval request has been created successfully.

@jerboaa thanks for the reply. I indeed missed that, sorry for the noice.

/approve yes

@jerboaa
8353950: The approval request has been approved.
8332271: The approval request has been approved.

/integrate

@matthiasblaesing
Your change (at version c2fade9) is now ready to be sponsored by a Committer.

@vieiro @jerboaa would one of you be willing to sponsor this change?

I'm not sure this will work (note sure if it's updated yet), but let's

/sponsor

@vieiro Only Committers are allowed to sponsor changes.

/sponsor

Going to push as commit dc28239.
Since your change was applied there have been 62 commits pushed to the master branch:

• 7b6ae46: 8345173: BlockLocationPrinter::print_location misses a ResourceMark
• 56f04e1: 8337506: Disable "best-fit" mapping on Windows command line
• 352a641: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
• ... and 59 more: https://git.openjdk.org/jdk21u-dev/compare/9a6ef52b82e66dfd5779f66113c28371ff2fd776...master

Your commit was automatically rebased without conflicts.

@jerboaa @matthiasblaesing Pushed as commit dc28239.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jerboaa thank you
@vieiro thank you too, I saw the vote thread on jdk-updates-dev and thus assumed, that the magic for your commit enablement had already happened 😄

@vieiro thank you too, I saw the vote thread on jdk-updates-dev and thus assumed, that the magic for your commit enablement had already happened 😄

Thank you @matthiasblaesing for backporting this! NetBeans users will be happy to see this on 21 by october.

Yeah, these things go slowly I imagine. I'll have to continue abusing committers for sponsoring meanwhile 😄